Use request->method for HTTP verb #2012
Conversation
|
Calling backup! @lonnieezell I think this is probably the correct way to handle this - however all the tests presume that routes will be matched off |
|
@MGatner Yes, I think that should work. Although we should be able to do away with the |
|
@lonnieezell These changes are in place. It's failing on |
|
Nevermind, it was supposed to be testing POST! Quick fix coming up. |
|
Looks good now! |
Description
By default the loaded route collection uses REQUEST_METHOD directly from $_SERVER:
$this->HTTPVerb = strtolower($_SERVER['REQUEST_METHOD'] ?? 'cli');
This means when Router->checkRoutes() matches its collection it uses the actual request method instead of the spoofed method from the Request object. This PR injects the proper HTTP verb prior using
$request->getMethod()To recreate the bug, create a resource route to a non-autorouted controller:
$routes->resource('foo', ['controller' =>'MyNamespace\Controllers\Foo']); And then try to access one of the non-POST supported methods by spoofing: Routing ignores the PUT routes and attempts to autoroute:Controller or its method is not found: App\Controllers\Foo`
Checklist: